Skip to content

Commit 7fc168f

Browse files
nuxynuxy
committed
Removed Promise wrapper example
1 parent 46afd1e commit 7fc168f

4 files changed

Lines changed: 45 additions & 105 deletions

File tree

‎test/e2e/async/handler/routes/Foo.js‎

Lines changed: 10 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -9,54 +9,39 @@ module.exports = {
99
* GET /api/<path>
1010
*/
1111
async index (req, res) {
12-
return new Promise(function(resolve) {
13-
res.setHeader('Content-Type', 'text/html');
14-
res.status(200).send('foo:index');
15-
resolve();
16-
});
12+
res.setHeader('Content-Type', 'text/html');
13+
res.status(200).send('foo:index');
1714
},
1815

1916
/**
2017
* PUT /api/<path>
2118
*/
2219
async create (req, res) {
23-
return new Promise(function(resolve) {
24-
res.setHeader('Content-Type', 'text/html');
25-
res.status(201).send('foo:create');
26-
resolve();
27-
});
20+
res.setHeader('Content-Type', 'text/html');
21+
res.status(201).send('foo:create');
2822
},
2923

3024
/**
3125
* PATCH /api/<path>
3226
*/
3327
async update (req, res) {
34-
return new Promise(function(resolve) {
35-
res.setHeader('Content-Type', 'text/html');
36-
res.status(204).send('foo:update');
37-
resolve();
38-
});
28+
res.setHeader('Content-Type', 'text/html');
29+
res.status(204).send('foo:update');
3930
},
4031

4132
/**
4233
* DELETE /api/<path>
4334
*/
4435
async delete (req, res) {
45-
return new Promise(function(resolve) {
46-
res.setHeader('Content-Type', 'text/html');
47-
res.status(410).send('foo:delete');
48-
resolve();
49-
});
36+
res.setHeader('Content-Type', 'text/html');
37+
res.status(410).send('foo:delete');
5038
},
5139

5240
/**
5341
* POST /api/<path>
5442
*/
5543
async submit (req, res) {
56-
return new Promise(function(resolve) {
57-
res.setHeader('Content-Type', 'text/html');
58-
res.status(200).send('foo:submit');
59-
resolve();
60-
});
44+
res.setHeader('Content-Type', 'text/html');
45+
res.status(200).send('foo:submit');
6146
}
6247
};

‎test/e2e/async/handler/routes/foo/Bar.js‎

Lines changed: 10 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -9,54 +9,39 @@ module.exports = {
99
* GET /api/<path>
1010
*/
1111
async index (req, res) {
12-
return new Promise(function(resolve) {
13-
res.setHeader('Content-Type', 'text/html');
14-
res.status(200).send('foo/bar:index');
15-
resolve();
16-
});
12+
res.setHeader('Content-Type', 'text/html');
13+
res.status(200).send('foo/bar:index');
1714
},
1815

1916
/**
2017
* PUT /api/<path>
2118
*/
2219
async create (req, res) {
23-
return new Promise(function(resolve) {
24-
res.setHeader('Content-Type', 'text/html');
25-
res.status(201).send('foo/bar:create');
26-
resolve();
27-
});
20+
res.setHeader('Content-Type', 'text/html');
21+
res.status(201).send('foo/bar:create');
2822
},
2923

3024
/**
3125
* PATCH /api/<path>
3226
*/
3327
async update (req, res) {
34-
return new Promise(function(resolve) {
35-
res.setHeader('Content-Type', 'text/html');
36-
res.status(204).send('foo/bar:update');
37-
resolve();
38-
});
28+
res.setHeader('Content-Type', 'text/html');
29+
res.status(204).send('foo/bar:update');;
3930
},
4031

4132
/**
4233
* DELETE /api/<path>
4334
*/
4435
async delete (req, res) {
45-
return new Promise(function(resolve) {
46-
res.setHeader('Content-Type', 'text/html');
47-
res.status(410).send('foo/bar:delete');
48-
resolve();
49-
});
36+
res.setHeader('Content-Type', 'text/html');
37+
res.status(410).send('foo/bar:delete');
5038
},
5139

5240
/**
5341
* POST /api/<path>
5442
*/
5543
async submit (req, res) {
56-
return new Promise(function(resolve) {
57-
res.setHeader('Content-Type', 'text/html');
58-
res.status(200).send('foo/bar:submit');
59-
resolve();
60-
});
44+
res.setHeader('Content-Type', 'text/html');
45+
res.status(200).send('foo/bar:submit');
6146
}
6247
};

‎test/e2e/async/handler/routes/foo/bar/Baz.js‎

Lines changed: 10 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -9,54 +9,39 @@ module.exports = {
99
* GET /api/<path>
1010
*/
1111
async index (req, res) {
12-
return new Promise(function(resolve) {
13-
res.setHeader('Content-Type', 'text/html');
14-
res.status(200).send('foo/bar/baz:index');
15-
resolve();
16-
});
12+
res.setHeader('Content-Type', 'text/html');
13+
res.status(200).send('foo/bar/baz:index');
1714
},
1815

1916
/**
2017
* PUT /api/<path>
2118
*/
2219
async create (req, res) {
23-
return new Promise(function(resolve) {
24-
res.setHeader('Content-Type', 'text/html');
25-
res.status(201).send('foo/bar/baz:create');
26-
resolve();
27-
});
20+
res.setHeader('Content-Type', 'text/html');
21+
res.status(201).send('foo/bar/baz:create');
2822
},
2923

3024
/**
3125
* PATCH /api/<path>
3226
*/
3327
async update (req, res) {
34-
return new Promise(function(resolve) {
35-
res.setHeader('Content-Type', 'text/html');
36-
res.status(204).send('foo/bar/baz:update');
37-
resolve();
38-
});
28+
res.setHeader('Content-Type', 'text/html');
29+
res.status(204).send('foo/bar/baz:update');
3930
},
4031

4132
/**
4233
* DELETE /api/<path>
4334
*/
4435
async delete (req, res) {
45-
return new Promise(function(resolve) {
46-
res.setHeader('Content-Type', 'text/html');
47-
res.status(410).send('foo/bar/baz:delete');
48-
resolve();
49-
});
36+
res.setHeader('Content-Type', 'text/html');
37+
res.status(410).send('foo/bar/baz:delete');
5038
},
5139

5240
/**
5341
* POST /api/<path>
5442
*/
5543
async submit (req, res) {
56-
return new Promise(function(resolve) {
57-
res.setHeader('Content-Type', 'text/html');
58-
res.status(200).send('foo/bar/baz:submit');
59-
resolve();
60-
});
44+
res.setHeader('Content-Type', 'text/html');
45+
res.status(200).send('foo/bar/baz:submit');
6146
}
6247
};

‎test/e2e/async/handler/routes/foo/bar/baz/Qux.js‎

Lines changed: 15 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -14,59 +14,44 @@ module.exports = {
1414
* GET /api/<path>/<resourceId>
1515
*/
1616
async get (req, res, id) {
17-
return new Promise(function(resolve) {
18-
res.setHeader('X-Request-ID', id);
19-
res.setHeader('Content-Type', 'application/json');
20-
res.status(200).json({get: true});
21-
resolve();
22-
});
17+
res.setHeader('X-Request-ID', id);
18+
res.setHeader('Content-Type', 'application/json');
19+
res.status(200).json({get: true});
2320
},
2421

2522
/**
2623
* PUT /api/<path>/<resourceId>
2724
*/
2825
async put (req, res, id) {
29-
return new Promise(function(resolve) {
30-
res.setHeader('X-Request-ID', id);
31-
res.setHeader('Content-Type', 'application/json');
32-
res.status(201).json({put: true});
33-
resolve();
34-
});
26+
res.setHeader('X-Request-ID', id);
27+
res.setHeader('Content-Type', 'application/json');
28+
res.status(201).json({put: true});
3529
},
3630

3731
/**
3832
* PATCH /api/<path>/<resourceId>
3933
*/
4034
async patch (req, res, id) {
41-
return new Promise(function(resolve) {
42-
res.setHeader('X-Request-ID', id);
43-
res.setHeader('Content-Type', 'application/json');
44-
res.status(204).json({patch: true});
45-
resolve();
46-
});
35+
res.setHeader('X-Request-ID', id);
36+
res.setHeader('Content-Type', 'application/json');
37+
res.status(204).json({patch: true});
4738
},
4839

4940
/**
5041
* DELETE /api/<path>/<resourceId>
5142
*/
5243
async delete (req, res, id) {
53-
return new Promise(function(resolve) {
54-
res.setHeader('X-Request-ID', id);
55-
res.setHeader('Content-Type', 'application/json');
56-
res.status(410).json({delete: true});
57-
resolve();
58-
});
44+
res.setHeader('X-Request-ID', id);
45+
res.setHeader('Content-Type', 'application/json');
46+
res.status(410).json({delete: true});
5947
},
6048

6149
/**
6250
* POST /api/<path>/<resourceId>
6351
*/
6452
async post (req, res, id) {
65-
return new Promise(function(resolve) {
66-
res.setHeader('X-Request-ID', id);
67-
res.setHeader('Content-Type', 'application/json');
68-
res.status(200).json({post: true});
69-
resolve();
70-
});
53+
res.setHeader('X-Request-ID', id);
54+
res.setHeader('Content-Type', 'application/json');
55+
res.status(200).json({post: true});
7156
}
7257
};

0 commit comments

Comments
 (0)