🚀 [@react-native-firebase/app] -Feature request: update dependencies

[vladimirivanoviliev]

What feature would you like to see?

I think it would be useful to update the following dependency as it's sub dependencies are already updated to improve react-native new architecture support:

• firebase@latest

This dependency brings update to the @firebase/auth and @firebase/auth-compat which will update @react-native-async-storage/async-storage to 2.1.0.

If I understand correctly Mike (@mikehardy, here), there is no other known issues when using the package with the react new architecture and bridge less mode.

[mikehardy]

I don't understand what the issue is. Also noting that @latest is not a valid tag for detailed discussion as it will move over time thus is ambiguous across time

[vladimirivanoviliev]

@mikehardy we are working on moving large app to the new react-native architecture and I'm currently looking at updating related dependencies. Noticed that @react-native-async-storage/async-storage released new major version 2.1.0 (link) with improvements on the new architecture. Checked the dependency tree and it seems this dependency can be updated (in the packages that use it). Also sorry for the confusion with @latest.

[mikehardy]

@vladimirivanoviliev this is a devDependency (not a dependency) and should have zero impact on consumers of this library?

react-native-firebase/packages/app/package.json

Lines 62 to 65 in 9b5c405

	"devDependencies": {
	"@react-native-async-storage/async-storage": "^1.24.0",
	"expo": "^50.0.21"
	},

Is this somehow impacting your use of react-native-async-storage/async-storage in your app such that you are not able to use v2.1.0 of that package via some resolution issue bringing in v1 ?

Regardless, sure, hadn't seen we were that out of date on it and should be updated (as devDependency and in tests app) - I just don't think it's user-visible so not sure it should be a priority vs if it was user-visible and had an impact on module consumers

[vladimirivanoviliev]

@mikehardy After closer look it seems that I made mistake - @react-native-async-storage/async-storage is marked as optional peer dependency in firebase->firebase/auth link, which should allow me to bump it in my project without issues?

[mikehardy]

Test it and see

[github-actions]

Hello 👋, to help manage issues we automatically close stale issues.

This issue has been automatically marked as stale because it has not had activity for quite some time.Has this issue been fixed, or does it still require attention?

This issue will be closed in 15 days if no further activity occurs.

Thank you for your contributions.