From 1a898b0a038fa86c3f5d7177ca36b11248a6e725 Mon Sep 17 00:00:00 2001 From: Brent Shaffer Date: Thu, 17 Sep 2026 13:32:12 -0700 Subject: [PATCH 1/3] Revert "fix(ci): patch BC check for internal final property fix (#9697)" This reverts commit 694bd0e4a94dc1d98451acec216a07e4a4821852. --- .github/workflows/release-checks.yaml | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/.github/workflows/release-checks.yaml b/.github/workflows/release-checks.yaml index efa69b69d3f6..1ef914f1ccb8 100644 --- a/.github/workflows/release-checks.yaml +++ b/.github/workflows/release-checks.yaml @@ -33,10 +33,7 @@ jobs: exit 1 fi - name: "Install dependencies" - run: | - composer global require "roave/backward-compatibility-check:^8.2" - # TODO: Remove this line after https://github.com/googleapis/google-cloud-php/pull/9697 is merged and released - sed -i.bak 's/return ($this->propertyBased)/return (new ExcludeInternalProperty($this->propertyBased))/' ~/.composer/vendor/roave/backward-compatibility-check/src/DetectChanges/BCBreak/PropertyBased/OnlyPublicPropertyChanged.php + run: composer global require "roave/backward-compatibility-check:^8.2" - name: "Check for BC breaks" if: github.event.pull_request.user.login != 'release-please[bot]' run: | From cb936d11aad6e3b02c2344a418278a0200d38af2 Mon Sep 17 00:00:00 2001 From: Brent Shaffer Date: Thu, 17 Sep 2026 13:33:34 -0700 Subject: [PATCH 2/3] Apply suggestion from @bshaffer --- .github/workflows/release-checks.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/release-checks.yaml b/.github/workflows/release-checks.yaml index 1ef914f1ccb8..51b6051682c8 100644 --- a/.github/workflows/release-checks.yaml +++ b/.github/workflows/release-checks.yaml @@ -33,7 +33,7 @@ jobs: exit 1 fi - name: "Install dependencies" - run: composer global require "roave/backward-compatibility-check:^8.2" + run: composer global require "roave/backward-compatibility-check:^8.22" - name: "Check for BC breaks" if: github.event.pull_request.user.login != 'release-please[bot]' run: | From be9c5be40b9d410de6c0c0569ec5e15deae11afc Mon Sep 17 00:00:00 2001 From: Brent Shaffer Date: Thu, 17 Sep 2026 13:41:19 -0700 Subject: [PATCH 3/3] Update PHP version from 8.2 to 8.4 in workflow --- .github/workflows/release-checks.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/release-checks.yaml b/.github/workflows/release-checks.yaml index 51b6051682c8..f5f0aae61c65 100644 --- a/.github/workflows/release-checks.yaml +++ b/.github/workflows/release-checks.yaml @@ -19,7 +19,7 @@ jobs: - name: "Install PHP" uses: shivammathur/setup-php@f3e473d116dcccaddc5834248c87452386958240 # v2 with: - php-version: "8.2" + php-version: "8.4" - name: "Rebase PR branch onto main branch" if: github.event.pull_request.user.login != 'release-please[bot]' env: