From 240edbc531b0ccefce5bc2ffa5aa53e7674012dd Mon Sep 17 00:00:00 2001 From: Brent Shaffer Date: Wed, 16 Sep 2026 18:26:30 +0000 Subject: [PATCH 1/2] fix(ci): patch BC check for internal final property fix --- .github/workflows/release-checks.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/release-checks.yaml b/.github/workflows/release-checks.yaml index 1ef914f1ccb8..11a9c9e1fdce 100644 --- a/.github/workflows/release-checks.yaml +++ b/.github/workflows/release-checks.yaml @@ -33,7 +33,9 @@ jobs: exit 1 fi - name: "Install dependencies" - run: composer global require "roave/backward-compatibility-check:^8.2" + run: | + composer global require "roave/backward-compatibility-check:^8.2" + sed -i.bak 's/return ($this->propertyBased)/return (new ExcludeInternalProperty($this->propertyBased))/' ~/.composer/vendor/roave/backward-compatibility-check/src/DetectChanges/BCBreak/PropertyBased/OnlyPublicPropertyChanged.php - name: "Check for BC breaks" if: github.event.pull_request.user.login != 'release-please[bot]' run: | From b3e6066bb8a0b5feda3bdbbc737193c8950a0147 Mon Sep 17 00:00:00 2001 From: Brent Shaffer Date: Wed, 16 Sep 2026 13:40:07 -0700 Subject: [PATCH 2/2] Apply suggestion from @bshaffer --- .github/workflows/release-checks.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/release-checks.yaml b/.github/workflows/release-checks.yaml index 11a9c9e1fdce..efa69b69d3f6 100644 --- a/.github/workflows/release-checks.yaml +++ b/.github/workflows/release-checks.yaml @@ -35,6 +35,7 @@ jobs: - name: "Install dependencies" run: | composer global require "roave/backward-compatibility-check:^8.2" + # TODO: Remove this line after https://github.com/googleapis/google-cloud-php/pull/9697 is merged and released sed -i.bak 's/return ($this->propertyBased)/return (new ExcludeInternalProperty($this->propertyBased))/' ~/.composer/vendor/roave/backward-compatibility-check/src/DetectChanges/BCBreak/PropertyBased/OnlyPublicPropertyChanged.php - name: "Check for BC breaks" if: github.event.pull_request.user.login != 'release-please[bot]'