Skip to content
This repository was archived by the owner on Oct 6, 2020. It is now read-only.
This repository was archived by the owner on Oct 6, 2020. It is now read-only.

Passing no callback to request so as to retrieve a stream causes crash #5

Description

@angadn

I think https://github.com/gitterHQ/request-http-cache/blob/master/lib/index.js#L243 should be
callback && callback(null, response, body); - should this fix it? I'd have PRed, but not sure if the module would still work as expected/cache and return a stream from Redis/cache

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions