fix: keep bare-repository worktrees non-bare (#2223)

Opening a linked worktree created from a bare repository read core.bare from the common repository and discarded the worktree path.

Keep a discovered linked worktree non-bare when its administrative directory has a commondir marker. The regression compares Git rev-parse behavior and verifies Repo.bare and working_tree_dir.

Git baseline: 0bd5a6920d7c4238e0d90ddc0e7e08866e84a0f1; environment.c:is_bare_repository() and setup.c:check_repository_format_gently(). Git 2.50.1 reports the linked checkout as non-bare.

Validation: 12 focused repository discovery/worktree tests and 7 test_base.py tests passed; ruff check, ruff format --check, and codespell passed.

Author: codex

git/repo/base.py

@@ -386,6 +386,10 @@ def __init__(
             # Let's not assume the option exists, although it should.
             pass
 
+        # A linked worktree is not bare even when its main repository is.
+        if self._bare and self._working_tree_dir and osp.isfile(osp.join(self.git_dir, "commondir")):
+            self._bare = False
+
         # Adjust the working directory in case we are actually bare - we didn't know
         # that in the first place.
         if self._bare:

test/test_repo.py

@@ -1459,6 +1459,18 @@ def test_git_work_tree_dotgit(self, rw_dir, use_relative_paths=False):
 
         self.assertIsInstance(repo.heads["aaaaaaaa"], Head)
 
+    @with_rw_directory
+    def test_git_work_tree_from_bare_repo(self, rw_dir):
+        bare_repo = self.rorepo.clone(join_path_native(rw_dir, "bare_repo"), bare=True)
+        worktree_path = join_path_native(rw_dir, "worktree_repo")
+        bare_repo.git.worktree("add", "--detach", worktree_path)
+
+        repo = Repo(worktree_path)
+
+        assert Git(worktree_path).rev_parse("--is-bare-repository") == "false"
+        assert not repo.bare
+        assert osp.samefile(repo.working_tree_dir, worktree_path)
+
     def test_git_work_tree_dotgit_relative(self):
         """Check that we find .git as a worktree file containing a relative path
         and find the worktree based on it."""