Skip to content

Server-Hang when Headers '\r' is the last char in buffer #178

Description

@mdeichsel

Describe the bug
The readLine-Function in HTTPConnection.cpp leads to end endless-loop, when the newChar is the last char in the buffer.
Then (_bufferProcessed+1 < _bufferUnusedIdx) is never true and the server loops.

How To Reproduce
with luck I got it with chrome.

Expected Behavior
Server hangs in loop without beeing responsive.

Actual Behavior
Handle Headers over buffer-borders

ESP32 Module
Please provide specifications of your module

  • RAM/PSRAM: ?
  • Flash Size: 4MB
  • Other special properties: ESP32-D0WDQ6 (revision 1) (ESP-DevKit)

Software (please complete the following information if applicable)

Additional context
I prepared a fix, try to submit a PR

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions