If we try to build a struct using incorrect types, then _pack() is correctly raising an error. However, the foreground thread just hangs when this happens.
This doesn't make sense to me--it's a client side error, so we should be able to fail loudly to the user. The error may be slightly cryptic because all the struct knows is that something is incorrect, it has no idea of the broader context. But at least it'd give the user something to go on...
This behavior may also apply to _unpack().
To reproduce, in _pack(), manually insert a conditional that flips a type:
def _pack(f, value):
try:
if isinstance(value, int):
value = str(value)
return pack(f, value)
except error:
raise ValueError(error)
See also #1318
If we try to build a struct using incorrect types, then
_pack()is correctly raising an error. However, the foreground thread just hangs when this happens.This doesn't make sense to me--it's a client side error, so we should be able to fail loudly to the user. The error may be slightly cryptic because all the struct knows is that something is incorrect, it has no idea of the broader context. But at least it'd give the user something to go on...
This behavior may also apply to
_unpack().To reproduce, in
_pack(), manually insert a conditional that flips a type:See also #1318