[Feature Request]: publish a jar for easier run and dynamic loading

[maxandersen]

spotless-cli version (if relevant)

I just noticed this repo - sorry for being late :)

any chance to publish the jar for this in addition to native binaries?

That could make this easily runnable with jbang and as mentioned in diffplug/spotless#527 (comment) enables easy add/remove of dependencies for somewhat dynamic config.

the native binaries i assume don't have that capability?

in any case - being able to run this without having to download a big platform specific binary would be nice IMO :)

Describe the feature

upload the .jar to github releases and/or maven central.

Motivation and use case

easy use of spotless without platform specific binaries.

Alternatives considered

No response

Feature scope

{"label" => "This should be implemented in spotless-cli."}

[maxandersen]

note, just spotted you are using jreleaser which has support for publishing releases to a jbang-catalog so could be as easy as running jbang spotless@diffplug

[simschla]

Thank you for this feature request @maxandersen 💡

I'm currently focusing my efforts on providing/implementing more formatters to the cli (currently distributed as a Graal binary).

Providing a distribution via (fat) jar should not be too difficult, but will require project restructuring and build adaptions to allow two separate ways of creating artifacts (and allowing dynamic class loading in one of them but not the other one).

If you have experience in that area and want to contribute, we would ❤️ that.

[maxandersen]

Doesn't default spotless-cli load from classpath ? I would think tbe Graal native image is tbe "odd" one out for this usecase ?

Happy to take a look though - any pointers to where the hard wiring is today ?

My thinking was to just make use of jbangs easy add to classpath feature and do:

jbang --deps additional-formatters spotlesscli

[simschla]

Doesn't default spotless-cli load from classpath ? I would think tbe Graal native image is tbe "odd" one out for this usecase ?
Happy to take a look though - any pointers to where the hard wiring is today ?

Yes, you are correct. But since spotless-cli is currently graalvm only, we hardwire the dynamic class loading (which is not supported in a java application running as a graal native image) here:
https://github.com/diffplug/spotless-cli/blob/main/app/src/main/java/com/diffplug/spotless/cli/core/CliJarProvisioner.java

That is something that needs to be included in the graalvm variant of the shadow jar only. For supporting a dynamic loading in a non-graal shadow jar, we would need a way to enable JarProvisioning independently of gradle and maven.

My thinking was to just make use of jbangs easy add to classpath feature and do:
jbang --deps additional-formatters spotlesscli

Sounds great, and I'm pretty sure you know just a little bit more about this approach than I do 😜

[wfouche]

A rough outline of how one could bootstrap SpotlessCLI using JBang:

./gradlew installDist

mvn install:install-file -Dfile=./app/build/libs/spotless-cli-0.3.1-SNAPSHOT.jar -DgroupId=com.diffplug.spotless -DartifactId=spotless-cli -Dversion=0.3.1 -Dpackaging=jar

jbang  run \
    --dep .... \
    --dep .... \
    --dep .... \
    --dep .... \
    com.diffplug.spotless:spotless-cli:0.3.1 --main com.diffplug.spotless.cli.SpotlessCLI -V