What happened
On PR #3529, both the review agent (run 33649841493) and human reviewer simonbaird independently identified that hack/release-branch-pipeline-patch.sh line 64 transforms main-pre-merge-build-args.conf into quick-build-args.conf — a file that does not exist in the repository. The PR author (dheerajodha) manually corrected the generated output to "" (empty string) after comparing with the v0.8 release branch. Simon confirmed: "Script is wrong IIUC." The author had to override the script's output on every release branch PR that uses it.
What could go better
The script produces incorrect pipeline YAML that must be manually corrected each time a new release branch is created. This creates two problems: (1) every future release branch PR will trigger the same review finding from both human and agent reviewers, wasting review attention on a known issue, and (2) if the manual correction is forgotten, the generated pull-request pipeline would reference a non-existent quick-build-args.conf file, potentially causing Tekton build failures. Confidence is high — both the human reviewer and the agent independently identified this as a bug, and the file's non-existence is verified.
Proposed change
In hack/release-branch-pipeline-patch.sh, change line 64 from gsub(/main-pre-merge-build-args.conf/, "quick-build-args.conf"); to gsub(/main-pre-merge-build-args.conf/, "\"\""); so that the pull-request pipeline's build-args-file parameter is set to empty string ("") rather than a non-existent file. This matches the pattern already used on line 65 for main-build-args.conf and aligns with what the PR author manually corrected to on the v0.8 and v0.9 release branches.
Validation criteria
After the fix, running hack/release-branch-pipeline-patch.sh for a new release branch should produce a pull-request pipeline YAML with build-args-file set to empty string rather than quick-build-args.conf. The next release branch setup PR should not trigger a build-args-file mismatch finding from the review agent.
Generated by retro agent from #3529
What happened
On PR #3529, both the review agent (run 33649841493) and human reviewer simonbaird independently identified that
hack/release-branch-pipeline-patch.shline 64 transformsmain-pre-merge-build-args.confintoquick-build-args.conf— a file that does not exist in the repository. The PR author (dheerajodha) manually corrected the generated output to""(empty string) after comparing with the v0.8 release branch. Simon confirmed: "Script is wrong IIUC." The author had to override the script's output on every release branch PR that uses it.What could go better
The script produces incorrect pipeline YAML that must be manually corrected each time a new release branch is created. This creates two problems: (1) every future release branch PR will trigger the same review finding from both human and agent reviewers, wasting review attention on a known issue, and (2) if the manual correction is forgotten, the generated pull-request pipeline would reference a non-existent
quick-build-args.conffile, potentially causing Tekton build failures. Confidence is high — both the human reviewer and the agent independently identified this as a bug, and the file's non-existence is verified.Proposed change
In
hack/release-branch-pipeline-patch.sh, change line 64 fromgsub(/main-pre-merge-build-args.conf/, "quick-build-args.conf");togsub(/main-pre-merge-build-args.conf/, "\"\"");so that the pull-request pipeline'sbuild-args-fileparameter is set to empty string ("") rather than a non-existent file. This matches the pattern already used on line 65 formain-build-args.confand aligns with what the PR author manually corrected to on the v0.8 and v0.9 release branches.Validation criteria
After the fix, running
hack/release-branch-pipeline-patch.shfor a new release branch should produce a pull-request pipeline YAML withbuild-args-fileset to empty string rather thanquick-build-args.conf. The next release branch setup PR should not trigger a build-args-file mismatch finding from the review agent.Generated by retro agent from #3529