Remove Q CLI pop-up notification from post-startup-notifications extension#236
Open
ShilpiParikh wants to merge 1 commit into
Open
Remove Q CLI pop-up notification from post-startup-notifications extension#236ShilpiParikh wants to merge 1 commit into
ShilpiParikh wants to merge 1 commit into
Conversation
…nsion The Amazon Q CLI notification is no longer needed as a post-startup popup in SageMaker Unified Studio Code Editor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Amazon Q CLI notification is no longer needed as a post-startup popup in SageMaker Unified Studio Code Editor.
Issue
Description of Changes
Remove the Q CLI pop-up notification ("The Amazon Q Command Line Interface (CLI) is installed...") from the post-startup-notifications extension. This removes the showQCliNotification function, its helper functions (hasUserSeen, markAsSeen), and associated unit tests. Post-startup script status notifications (error/in-progress) remain functional.
Testing
Screenshots/Videos
Additional Notes
Change is limited to
/patches/sagemaker/post-startup-notifications.diffBackporting
This change has been backported to branches 1.0, 1.1, and 1.2 via separate PRs.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.