address missed Copilot review

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

Author: shwstppr

core/src/main/java/org/apache/cloudstack/vm/bootgroup/readiness/InstanceReadinessCheckAnswer.java

@@ -37,8 +37,9 @@ public InstanceReadinessCheckAnswer(InstanceReadinessCheckCommand cmd, boolean r
 
     public Map<String, String> getExecutionDetails() {
         final Map<String, String> executionDetails = new HashMap<>();
-        if (getResult() && StringUtils.isNotEmpty(getDetails())) {
-            final String[] parts = getDetails().split("&&");
+        final String details = getDetails();
+        if (StringUtils.isNotEmpty(details) && details.contains("&&")) {
+            final String[] parts = details.split("&&");
             if (parts.length >= 3) {
                 executionDetails.put(STDOUT, parts[0].trim());
                 executionDetails.put(STDERR, parts[1].trim());
@@ -48,7 +49,7 @@ public Map<String, String> getExecutionDetails() {
             }
         } else {
             executionDetails.put(STDOUT, "");
-            executionDetails.put(STDERR, getDetails());
+            executionDetails.put(STDERR, details);
             executionDetails.put(EXITCODE, "-1");
         }
         return executionDetails;

core/src/test/java/org/apache/cloudstack/vm/bootgroup/readiness/InstanceReadinessCheckAnswerTest.java

@@ -56,14 +56,36 @@ public void malformedSuccessfulDetailsThrow() {
         new InstanceReadinessCheckAnswer(cmd(), true, "out&&err").getExecutionDetails();
     }
 
+    @Test(expected = CloudRuntimeException.class)
+    public void malformedFailedDetailsThrow() {
+        new InstanceReadinessCheckAnswer(cmd(), false, "out&&err").getExecutionDetails();
+    }
+
+    @Test
+    public void failedResultIsStillParsedWhenWellFormed() {
+        // executeInVR (and the VR script) typically reports result=false whenever the underlying
+        // check (ping unreachable, port closed) exits non-zero, even though it still printed a
+        // well-formed "stdout&&stderr&&exitcode" triple. The non-zero exit code must not be
+        // discarded in favor of a generic -1/raw-blob fallback.
+        InstanceReadinessCheckAnswer answer = new InstanceReadinessCheckAnswer(cmd(), false, "out&&unreachable&&1");
+
+        Map<String, String> details = answer.getExecutionDetails();
+
+        Assert.assertEquals("out", details.get(InstanceReadinessCheckAnswer.STDOUT));
+        Assert.assertEquals("unreachable", details.get(InstanceReadinessCheckAnswer.STDERR));
+        Assert.assertEquals("1", details.get(InstanceReadinessCheckAnswer.EXITCODE));
+    }
+
     @Test
-    public void failedResultIsNotParsedEvenIfWellFormed() {
-        InstanceReadinessCheckAnswer answer = new InstanceReadinessCheckAnswer(cmd(), false, "out&&err&&0");
+    public void failedResultWithoutDelimiterFallsBackToDefaults() {
+        // A dispatch-level failure (e.g. an exception message) never contains the delimiter and
+        // must still fall back to the raw-message/-1 defaults rather than throwing.
+        InstanceReadinessCheckAnswer answer = new InstanceReadinessCheckAnswer(cmd(), false, "agent down");
 
         Map<String, String> details = answer.getExecutionDetails();
 
         Assert.assertEquals("", details.get(InstanceReadinessCheckAnswer.STDOUT));
-        Assert.assertEquals("out&&err&&0", details.get(InstanceReadinessCheckAnswer.STDERR));
+        Assert.assertEquals("agent down", details.get(InstanceReadinessCheckAnswer.STDERR));
         Assert.assertEquals("-1", details.get(InstanceReadinessCheckAnswer.EXITCODE));
     }