fix(ui): shorten conversion host labels

Author: andrijapanicsb

ui/src/utils/vmware.js

@@ -0,0 +1,41 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+export const formatKvmConversionHostName = (host, migrationMode, yes, no) => {
+  const details = host.details || {}
+  const isSupported = value => value === true || value === 'true'
+  const hostParts = [host.name]
+  const capabilityParts = []
+
+  if (host.clustername) {
+    hostParts.push(`[${host.clustername}]`)
+  }
+
+  const virtV2vVersion = details['host.virtv2v.version']
+  capabilityParts.push(`virt-v2v=${virtV2vVersion || (isSupported(host.instanceconversionsupported) ? yes : no)}`)
+
+  if (migrationMode === 'cbt' || migrationMode === 'vddk') {
+    const vddkSupported = isSupported(details['host.vddk.support'])
+    const vddkVersion = details['host.vddk.version']
+    capabilityParts.push(`VDDK=${vddkSupported ? (vddkVersion || yes) : no}`)
+  }
+  if (migrationMode === 'cbt') {
+    capabilityParts.push(`CBT=${isSupported(details['host.vddk.blockcopy.support']) ? yes : no}`)
+  }
+
+  return `${hostParts.join(' ')} — ${capabilityParts.join(' / ')}`
+}

ui/src/views/tools/ImportUnmanagedInstance.vue

@@ -460,6 +460,7 @@ import MultiNetworkSelection from '@views/compute/wizard/MultiNetworkSelection'
 import OsLogo from '@/components/widgets/OsLogo'
 import ResourceIcon from '@/components/view/ResourceIcon'
 import CheckBoxSelectPair from '@/components/CheckBoxSelectPair'
+import { formatKvmConversionHostName } from '@/utils/vmware'
 
 export default {
   name: 'ImportUnmanagedInstances',
@@ -1111,47 +1112,13 @@ export default {
         this.kvmHostsForConversion = this.kvmHostsForConversion.filter(host => ['Enabled', 'Disabled'].includes(host.resourcestate))
         // Check if any host has VDDK support
         let hasVddkSupport = false
-        this.kvmHostsForConversion.map(host => {
-          host.name = host.name + ' [Pod=' + host.podname + '] [Cluster=' + host.clustername + ']'
-          if (host.instanceconversionsupported !== null && host.instanceconversionsupported !== undefined && host.instanceconversionsupported) {
-            host.name = host.name + ' (' + this.$t('label.supported') + ')'
-          } else {
-            host.name = host.name + ' (' + this.$t('label.not.supported') + ')'
-          }
-          if (host.details['host.virtv2v.version']) {
-            host.name = host.name + ' (virt-v2v=' + host.details['host.virtv2v.version'] + ')'
-          }
-          if (host.details['host.ovftool.version']) {
-            host.name = host.name + ' (ovftool=' + host.details['host.ovftool.version'] + ')'
-          }
+        this.kvmHostsForConversion.forEach(host => {
+          const details = host.details || {}
           // Check for VDDK support
-          if (host.details['host.vddk.support'] === 'true' || host.details['host.vddk.support'] === true) {
+          if (details['host.vddk.support'] === 'true' || details['host.vddk.support'] === true) {
             hasVddkSupport = true
           }
-
-          if (this.form.usevddk) {
-            if (host.details['host.vddk.support'] === 'true' || host.details['host.vddk.support'] === true) {
-              host.name = host.name + ' (VDDK=' + this.$t('label.supported') + ')'
-            } else {
-              host.name = host.name + ' (VDDK=' + this.$t('label.not.supported') + ')'
-            }
-            if (host.details['host.vddk.version']) {
-              host.name = host.name + ' (vddk=' + host.details['host.vddk.version'] + ')'
-            }
-          }
-          if (this.form.vmwaremigrationmode === 'cbt') {
-            if (host.details['host.vddk.blockcopy.support'] === 'true' || host.details['host.vddk.blockcopy.support'] === true) {
-              host.name = host.name + ' (' + this.$t('label.host.vmware.cbt.data.copy.support') + '=' + this.$t('label.supported') + ')'
-            } else {
-              host.name = host.name + ' (' + this.$t('label.host.vmware.cbt.data.copy.support') + '=' + this.$t('label.not.supported') + ')'
-            }
-            if (host.details['host.qemu.img.version']) {
-              host.name = host.name + ' (qemu-img=' + host.details['host.qemu.img.version'] + ')'
-            }
-            if (host.details['host.qemu.nbd.version']) {
-              host.name = host.name + ' (qemu-nbd=' + host.details['host.qemu.nbd.version'] + ')'
-            }
-          }
+          host.name = this.formatKvmConversionHostName(host)
         })
 
         // Enable usevddk by default if at least one host has VDDK support
@@ -1161,6 +1128,13 @@ export default {
         }
       })
     },
+    formatKvmConversionHostName (host) {
+      return formatKvmConversionHostName(
+        host,
+        this.form.vmwaremigrationmode,
+        this.$t('label.yes'),
+        this.$t('label.no'))
+    },
     fetchKvmHostsForImporting () {
       getAPI('listHosts', {
         clusterid: this.cluster.id,

ui/tests/unit/utils/vmware.spec.js

@@ -0,0 +1,51 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+import { formatKvmConversionHostName } from '@/utils/vmware'
+
+const host = {
+  name: 'qa1-vmwarelab-576a1b2a-mix-host2',
+  podname: 'Pod',
+  clustername: 'KVM-Cluster',
+  instanceconversionsupported: true,
+  details: {
+    'host.virtv2v.version': '2.7.1rhel=9',
+    'host.vddk.support': 'true',
+    'host.vddk.version': '8',
+    'host.vddk.blockcopy.support': 'true',
+    'host.qemu.img.version': '7.0.0',
+    'host.qemu.nbd.version': 'qemu-nbd 7.0.0 (qemu-kvm-7.0.0-13.el9)'
+  }
+}
+
+describe('utils/vmware', () => {
+  describe('formatKvmConversionHostName()', () => {
+    it('shows a concise CBT conversion host label', () => {
+      expect(formatKvmConversionHostName(host, 'cbt', 'Yes', 'No')).toBe(
+        'qa1-vmwarelab-576a1b2a-mix-host2 [KVM-Cluster] — virt-v2v=2.7.1rhel=9 / VDDK=8 / CBT=Yes')
+    })
+
+    it('does not expose low-level QEMU or Pod details in the selector', () => {
+      const label = formatKvmConversionHostName(host, 'cbt', 'Yes', 'No')
+
+      expect(label).not.toContain('qemu-img')
+      expect(label).not.toContain('qemu-nbd')
+      expect(label).not.toContain('Pod')
+      expect(label).not.toContain('Supported')
+    })
+  })
+})