Skip to content

Commit 23b612b

Browse files
PrashantBhanageDaanHoogland
authored andcommitted
fix: add proper imports for java.security.cert classes and fix indentation
1 parent 7dd2263 commit 23b612b

1 file changed

Lines changed: 8 additions & 5 deletions

File tree

‎server/src/main/java/com/cloud/api/ApiResponseHelper.java‎

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,9 @@
3737
import java.util.function.Consumer;
3838
import java.util.stream.Collectors;
3939

40+
import java.security.cert.Certificate;
41+
import java.security.cert.CertificateException;
42+
import java.security.cert.X509Certificate;
4043
import javax.inject.Inject;
4144

4245
import org.apache.cloudstack.acl.ControlledEntity;
@@ -5466,18 +5469,18 @@ public NetworkPermissionsResponse createNetworkPermissionsResponse(NetworkPermis
54665469
return response;
54675470
}
54685471

5469-
protected void handleCertificateResponse(String certStr, DirectDownloadCertificateResponse response) {
5472+
protected void handleCertificateResponse(String certStr, DirectDownloadCertificateResponse response) {
54705473
try {
5471-
java.security.cert.Certificate cert = CertificateHelper.buildCertificate(certStr);
5472-
if (cert instanceof java.security.cert.X509Certificate) {
5473-
java.security.cert.X509Certificate certificate = (java.security.cert.X509Certificate) cert;
5474+
Certificate cert = CertificateHelper.buildCertificate(certStr);
5475+
if (cert instanceof X509Certificate) {
5476+
X509Certificate certificate = (X509Certificate) cert;
54745477
response.setVersion(String.valueOf(certificate.getVersion()));
54755478
response.setSubject(certificate.getSubjectDN().toString());
54765479
response.setIssuer(certificate.getIssuerDN().toString());
54775480
response.setSerialNum(certificate.getSerialNumber().toString());
54785481
response.setValidity(String.format("From: [%s] - To: [%s]", certificate.getNotBefore(), certificate.getNotAfter()));
54795482
}
5480-
} catch (java.security.cert.CertificateException e) {
5483+
} catch (CertificateException e) {
54815484
logger.error("Error parsing direct download certificate: " + certStr, e);
54825485
}
54835486
}

0 commit comments

Comments
 (0)