Skip to content

conformance.md opt-out example instantiates the static FeatureSet class #57

Description

@nficano

Category: docs Severity: major
Location: docs/conformance.md:60-65

What

FeatureSet is a static class (src/Arcp.Core/Capabilities/Capabilities.cs:79) with no constructor, and ArcpClientOptions.Features is IReadOnlyList? (src/Arcp.Client/ArcpClientOptions.cs:21). new FeatureSet([...]) cannot compile.

Evidence

new ArcpClientOptions
{
    Features = new FeatureSet(["heartbeat", "ack"]), // drop the rest
};

Proposed fix

Use Features = new[] { FeatureFlags.Heartbeat, FeatureFlags.Ack } as sessions.md does.

Acceptance criteria

  • The example assigns a string list to Features and compiles.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    audit/docsAudit: documentation inaccuracysev/majorSeverity: major

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions