From 3d99fb58cfb6cd5d0c14f78e9f38a81a3243e590 Mon Sep 17 00:00:00 2001 From: mohanadft Date: Tue, 18 Aug 2026 22:10:06 +0300 Subject: [PATCH 1/2] fix(membership): let Qgiv embed height flex instead of capping at 720px The 720px max-height clipped taller variants of the Qgiv form; letting the iframe follow Qgiv's own resize behavior fixes both /membership and /supporting-member since they share QgivJoin via LegacyJoinSection. --- src/components/membership/QgivJoin.tsx | 9 --------- 1 file changed, 9 deletions(-) diff --git a/src/components/membership/QgivJoin.tsx b/src/components/membership/QgivJoin.tsx index ccce72f7..9a64f958 100644 --- a/src/components/membership/QgivJoin.tsx +++ b/src/components/membership/QgivJoin.tsx @@ -242,15 +242,6 @@ export default function QgivJoin({ tier, className, prefill }: QgivJoinProps) { data-width="630" /> - {/* Qgiv's embed.js sets a default iframe height (observed: 1000px) via - the `height` HTML attribute, then narrows it once its resize - postMessage fires — which hasn't reliably landed here, leaving dead - space below the visibly shorter membership form. `/donate` and - `/donate-new` hit the same issue and fix it the same way: a plain - CSS rule beats an HTML attribute in the cascade without needing - `!important`, capping the iframe box directly rather than a - wrapping element Qgiv's script may detach from. */} - ); } From 6c7ce53cee41caca4779b207e3063ff8cf8603ea Mon Sep 17 00:00:00 2001 From: mohanadft Date: Tue, 18 Aug 2026 22:28:56 +0300 Subject: [PATCH 2/2] fix(membership): cap Qgiv embed height at 950px instead of leaving it unbounded 720px clipped taller form variants; removing the cap entirely left Qgiv's unresized 1000px default showing as dead space. 950px splits the difference. --- src/components/membership/QgivJoin.tsx | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/components/membership/QgivJoin.tsx b/src/components/membership/QgivJoin.tsx index 9a64f958..af105998 100644 --- a/src/components/membership/QgivJoin.tsx +++ b/src/components/membership/QgivJoin.tsx @@ -242,6 +242,14 @@ export default function QgivJoin({ tier, className, prefill }: QgivJoinProps) { data-width="630" /> + {/* Qgiv's embed.js sets a default iframe height (observed: 1000px) via + the `height` HTML attribute, then narrows it once its resize + postMessage fires — which hasn't reliably landed here, leaving dead + space below the visibly shorter membership form. Capping at 950px + (vs. clamping to something like 720px) still fits the tallest + real-world variant of the form while trimming the worst of the + unresized default. */} + ); }