You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Two housekeeping follow-ups from the #3 review, both low priority.
capturingWriter (internal/engine/requestlog/recorder.go) buffers the entire response body in memory before capping the persisted capture at 64 KB. The request side got a proper tee in Engine body limit + req host, photos and graph media planes for migration e2e #3; the response side still duplicates multi-MB media responses (items/{id}/content, media-dl) in memory for the request lifetime. Same tee treatment would fix it.
graph-style upload sessions that are never completed leave their session doc and up-{id} partial blob behind forever, and each mid-session chunk rewrites the full accumulated blob (quadratic I/O for many small chunks). Fine for a localhost test tool; worth an expiry sweep or append-capable blob primitive if multi-GB fixtures ever matter.
Two housekeeping follow-ups from the #3 review, both low priority.
capturingWriter (internal/engine/requestlog/recorder.go) buffers the entire response body in memory before capping the persisted capture at 64 KB. The request side got a proper tee in Engine body limit + req host, photos and graph media planes for migration e2e #3; the response side still duplicates multi-MB media responses (items/{id}/content, media-dl) in memory for the request lifetime. Same tee treatment would fix it.
graph-style upload sessions that are never completed leave their session doc and up-{id} partial blob behind forever, and each mid-session chunk rewrites the full accumulated blob (quadratic I/O for many small chunks). Fine for a localhost test tool; worth an expiry sweep or append-capable blob primitive if multi-GB fixtures ever matter.