From b8fbbea5f403d54d8214899e91c42acf5e1b1943 Mon Sep 17 00:00:00 2001 From: Huy Nguyen Date: Thu, 14 May 2026 06:40:34 +1000 Subject: [PATCH] Fix: runbook snapshot create drops interactive --package overrides. The interactive flow wrote resolved overrides to opts.PackageVersionOverrides while the build loop read from opts.PackageVersionSpec.Value, so overrides typed at the package prompt never reached the server. --- pkg/cmd/runbook/snapshot/create/create.go | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/pkg/cmd/runbook/snapshot/create/create.go b/pkg/cmd/runbook/snapshot/create/create.go index 71a5a57b..39aad8ae 100644 --- a/pkg/cmd/runbook/snapshot/create/create.go +++ b/pkg/cmd/runbook/snapshot/create/create.go @@ -68,7 +68,6 @@ func NewCreateFlags() *CreateFlags { type CreateOptions struct { *CreateFlags - PackageVersionOverrides []string *shared.RunbooksOptions GetAllProjectsCallback shared.GetAllProjectsCallback *cmd.Dependencies @@ -351,7 +350,7 @@ func PromptMissing(opts *CreateOptions) error { _, packageVersionOverrides, err := packages.AskPackageOverrideLoop( packageVersionBaseline, opts.PackageVersion.Value, - opts.PackageVersionOverrides, + opts.PackageVersionSpec.Value, opts.Ask, opts.Out) @@ -360,9 +359,9 @@ func PromptMissing(opts *CreateOptions) error { } if len(packageVersionOverrides) > 0 { - opts.PackageVersionOverrides = make([]string, 0, len(packageVersionOverrides)) + opts.PackageVersionSpec.Value = make([]string, 0, len(packageVersionOverrides)) for _, ov := range packageVersionOverrides { - opts.PackageVersionOverrides = append(opts.PackageVersionOverrides, ov.ToPackageOverrideString()) + opts.PackageVersionSpec.Value = append(opts.PackageVersionSpec.Value, ov.ToPackageOverrideString()) } } }