Skip to content

fix prefill_params when prefill num_reqs > 1024#1336

Merged
hiworldwzj merged 1 commit into
mainfrom
prefill_para_fix
Jun 8, 2026
Merged

fix prefill_params when prefill num_reqs > 1024#1336
hiworldwzj merged 1 commit into
mainfrom
prefill_para_fix

Conversation

@shihaobai

Copy link
Copy Markdown
Collaborator

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes a bug in the _gen_cumsum_pad0_kernel function within lightllm/common/basemodel/triton_kernel/gen_prefill_params.py. It corrects the memory offset calculation inside the loop by replacing offs with current_offs when loading b_q_seq_len and b_kv_seq_len, ensuring the correct data is loaded for each iteration. No review comments were provided, so there is no additional feedback to address.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@hiworldwzj hiworldwzj merged commit 5514e24 into main Jun 8, 2026
1 check passed
@hiworldwzj hiworldwzj deleted the prefill_para_fix branch June 8, 2026 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants