Lending pool-management messages are untested: pool lifecycle beyond borrow is uncovered

[nanaf6203-bit]

Lending pool-management messages are untested: pool lifecycle beyond borrow is uncovered

Labels / Complexity: Contract · Rust · Trivial — Trivial

Summary

contracts/lending/src/lib.rs has 32 ink::test functions, but the pool-management edges are not among them: create_pool (line 2188 is only referenced in a test as a setup call), pool deposit/withdraw, and the pool-limit enforcement paths have no dedicated tests. A grep of the test module shows coverage of borrow/repay/liquidation basics; the pool configuration surface (limits, rates, admin setters) is unpinned.

Proposal

• Add tests for: pool creation (auth), deposit/withdraw accounting, and the pool-limit rejection (deposits below borrows+amount, the unchecked-arithmetic site at line 929).

Acceptance criteria

• Pool create/deposit/withdraw and the limit rejection are asserted in tests.
• cargo test -p propchain-lending passes.

Getting started

Files: contracts/lending/src/lib.rs (lines 925-950), contracts/lending/src/tests.rs. Command: cargo test -p propchain-lending.

[chiprime]

@chiprime has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Hello Maintainer, I can fix this.
Please assign me.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @chiprime to this issue.

[Agaki00]

@Agaki00 has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Hello..
It with pleasure that I am applying to work on this issue if given the chance.
Thank you.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Agaki00 to this issue.

[drips-wave]

Congratulations, @Agaki00! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on August 31, 2026.

🧑‍💻 @Agaki00: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊