Note: This work has been split into two sub-issues for review — see below.
Algorithm Description:
In a Hi tag-up meeting, Paul pointed out the problem with my implementation in recent PR that added gain test filtering and geometric factor lookup to L1B DE/ L1C (#3358).
- Update to gain tests logic:
- Don't use lookup table
- look at voltages for first HVSCI (first ~3 packets), anything away from these voltages is gain test and should be removed. Can hard code delta values in the existing Hi utils.py where constants like this are defined.
- Geometric factor update:
- use time and voltages to lookup geometric factor. Time b/c we may have time dependent geometric factors. Note that existing implementation of ancillary files allows for time dependent factors already.
- Key values for geometric factor lookup are difference between front and back detector voltages + tof. HV variables: tof_v, mcp_f_v, mcp_b_v, cem_f_v, cem_bk_a_v, cem_bk_b_v
Note: This work has been split into two sub-issues for review — see below.
Algorithm Description:
In a Hi tag-up meeting, Paul pointed out the problem with my implementation in recent PR that added gain test filtering and geometric factor lookup to L1B DE/ L1C (#3358).