fix: handle exceptions directly in UI scripts

- inference
- tts
Initially attempted to move error handling to core.py, but overlooked that the existing code already handles exception propagation. Relocating capture to inference.py and tts.py for proper UI feedback.

Author: Vidalnt

core.py

@@ -1,24 +1,24 @@
-import os
-import sys
-import json
 import argparse
+import json
+import os
 import subprocess
-from functools import lru_cache
+import sys
 import traceback
 from distutils.util import strtobool
+from functools import lru_cache
 
 now_dir = os.getcwd()
 sys.path.append(now_dir)
 
 current_script_directory = os.path.dirname(os.path.realpath(__file__))
 logs_path = os.path.join(current_script_directory, "logs")
 
-from rvc.lib.tools.prerequisites_download import prequisites_download_pipeline
-from rvc.train.process.model_blender import model_blender
-from rvc.train.process.model_information import model_information
 from rvc.lib.tools.analyzer import analyze_audio
 from rvc.lib.tools.launch_tensorboard import launch_tensorboard_pipeline
 from rvc.lib.tools.model_download import model_download_pipeline
+from rvc.lib.tools.prerequisites_download import prequisites_download_pipeline
+from rvc.train.process.model_blender import model_blender
+from rvc.train.process.model_information import model_information
 
 python = sys.executable
 
@@ -122,8 +122,6 @@ def run_infer_script(
         "index_rate": index_rate,
         "protect": protect,
         "f0_method": f0_method,
-        "pth_path": pth_path,
-        "index_path": index_path,
         "split_audio": split_audio,
         "f0_autotune": f0_autotune,
         "f0_autotune_strength": f0_autotune_strength,
@@ -175,18 +173,11 @@ def run_infer_script(
         "delay_mix": delay_mix,
         "sid": sid,
     }
-    try:
-        infer_pipeline = import_voice_converter()
-        infer_pipeline.convert_audio(**kwargs)
-        return f"File {input_path} inferred successfully.", output_path.replace(
-            ".wav", f".{export_format.lower()}"
-        )
-    except Exception:
-        traceback.print_exc()
-        return (
-            "An error occurred during audio conversion. Check the console for details.",
-            None,
-        )
+    infer_pipeline = import_voice_converter()
+    infer_pipeline.convert_audio(**kwargs)
+    return f"File {input_path} inferred successfully.", output_path.replace(
+        ".wav", f".{export_format.lower()}"
+    )
 
 
 # Batch infer
@@ -261,8 +252,6 @@ def run_batch_infer_script(
         "volume_envelope": volume_envelope,
         "protect": protect,
         "f0_method": f0_method,
-        "pth_path": pth_path,
-        "index_path": index_path,
         "split_audio": split_audio,
         "f0_autotune": f0_autotune,
         "f0_autotune_strength": f0_autotune_strength,
@@ -314,13 +303,9 @@ def run_batch_infer_script(
         "delay_mix": delay_mix,
         "sid": sid,
     }
-    try:
-        infer_pipeline = import_voice_converter()
-        infer_pipeline.convert_audio_batch(**kwargs)
-        return f"Files from {input_folder} inferred successfully."
-    except Exception:
-        traceback.print_exc()
-        return "An error occurred during audio batch conversion. Check the console for details."
+    infer_pipeline = import_voice_converter()
+    infer_pipeline.convert_audio_batch(**kwargs)
+    return f"Files from {input_folder} inferred successfully."
 
 
 # TTS
@@ -371,7 +356,7 @@ def run_tts_script(
             ],
         ),
     ]
-    subprocess.run(command_tts)
+    subprocess.run(command_tts, check=True)
     infer_pipeline = import_voice_converter()
     infer_pipeline.convert_audio(
         pitch=pitch,
@@ -397,7 +382,7 @@ def run_tts_script(
         formant_shifting=None,
         formant_qfrency=None,
         formant_timbre=None,
-        post_process=None,
+        post_process=False,
         reverb=None,
         pitch_shift=None,
         limiter=None,

rvc/lib/tools/tts.py

@@ -1,28 +1,29 @@
-import sys
 import asyncio
-import edge_tts
 import os
-
+import sys
+import edge_tts
 
 async def main():
-    # Parse command line arguments
     tts_file = str(sys.argv[1])
     text = str(sys.argv[2])
     voice = str(sys.argv[3])
     rate = int(sys.argv[4])
     output_file = str(sys.argv[5])
 
     rates = f"+{rate}%" if rate >= 0 else f"{rate}%"
+
     if tts_file and os.path.exists(tts_file):
-        text = ""
         try:
             with open(tts_file, "r", encoding="utf-8") as file:
                 text = file.read()
-        except UnicodeDecodeError:
+        except:
             with open(tts_file, "r") as file:
                 text = file.read()
-    await edge_tts.Communicate(text, voice, rate=rates).save(output_file)
-    # print(f"TTS with {voice} completed. Output TTS file: '{output_file}'")
+
+    try:
+        await edge_tts.Communicate(text, voice, rate=rates).save(output_file)
+    except Exception:
+        sys.exit(1)
 
 
 if __name__ == "__main__":

tabs/inference/inference.py

@@ -3,6 +3,7 @@
 import os
 import shutil
 import sys
+import traceback
 
 import gradio as gr
 import regex as re
@@ -474,7 +475,7 @@ def get_speakers_id(model):
                 return list(range(speakers_id))
             else:
                 return [0]
-        except Exception as e:
+        except Exception:
             return [0]
     else:
         return [0]
@@ -1174,14 +1175,25 @@ def enforce_terms(terms_accepted, *args):
                 message = "You must agree to the Terms of Use to proceed."
                 gr.Info(message)
                 return message, None
-            return run_infer_script(*args)
+            try:
+                return run_infer_script(*args)
+            except Exception:
+                traceback.print_exc()
+                return (
+                    "An error occurred during audio conversion. Check the console for details.",
+                    None,
+                )
 
         def enforce_terms_batch(terms_accepted, *args):
             if not terms_accepted:
                 message = "You must agree to the Terms of Use to proceed."
                 gr.Info(message)
                 return message
-            return run_batch_infer_script(*args)
+            try:
+                return run_batch_infer_script(*args)
+            except Exception:
+                traceback.print_exc()
+                return "An error occurred during audio batch conversion. Check the console for details."
 
         terms_checkbox = gr.Checkbox(
             label=i18n("I agree to the terms of use"),

tabs/tts/tts.py

@@ -2,6 +2,7 @@
 import os
 import random
 import sys
+import traceback
 
 import gradio as gr
 
@@ -10,19 +11,19 @@
 
 from assets.i18n.i18n import I18nAuto
 from core import run_tts_script
-from tabs.settings.sections.filter import get_filter_trigger, load_config_filter
 from tabs.inference.inference import (
     change_choices,
     create_folder_and_move_files,
+    default_weight,
+    extract_model_and_epoch,
+    filter_dropdowns,
     get_files,
     get_speakers_id,
     match_index,
     refresh_embedders_folders,
-    extract_model_and_epoch,
-    default_weight,
-    filter_dropdowns,
     update_filter_visibility,
 )
+from tabs.settings.sections.filter import get_filter_trigger, load_config_filter
 
 i18n = I18nAuto()
 
@@ -357,7 +358,14 @@ def enforce_terms(terms_accepted, *args):
             message = "You must agree to the Terms of Use to proceed."
             gr.Info(message)
             return message, None
-        return run_tts_script(*args)
+        try:
+            return run_tts_script(*args)
+        except Exception:
+            traceback.print_exc()
+            return (
+                "An error occurred during TTS conversion. Check the console for details.",
+                None,
+            )
 
     terms_checkbox = gr.Checkbox(
         label=i18n("I agree to the terms of use"),