diff --git a/samples/python/uff_ssd/utils/model.py b/samples/python/uff_ssd/utils/model.py index 5a407d3..ca557a9 100644 --- a/samples/python/uff_ssd/utils/model.py +++ b/samples/python/uff_ssd/utils/model.py @@ -182,7 +182,26 @@ def _extract_model(silent=False): model_archive_path = PATHS.get_data_file_path('ssd_inception_v2_coco_2017_11_17.tar.gz') maybe_print(not silent, "Unpacking {}".format(model_archive_path)) with tarfile.open(model_archive_path, "r:gz") as tar: - tar.extractall(path=model_dir) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar, path=model_dir) maybe_print(not silent, "Model ready") def prepare_ssd_model(model_name="ssd_inception_v2_coco_2017_11_17", silent=False): diff --git a/samples/python/uff_ssd/voc_evaluation.py b/samples/python/uff_ssd/voc_evaluation.py index 8f68016..fa41ac5 100644 --- a/samples/python/uff_ssd/voc_evaluation.py +++ b/samples/python/uff_ssd/voc_evaluation.py @@ -354,7 +354,26 @@ def extract_voc_data_if_needed(): voc_archive_path = PATHS.get_data_file_path('VOCtest_06-Nov-2007.tar') print("Unpacking {}".format(voc_archive_path)) with tarfile.open(voc_archive_path, "r") as tar: - tar.extractall(path=PATHS.get_sample_root()) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar, path=PATHS.get_sample_root()) print("Unpacking done!")