London | 26-MAY-ITP | Yonatan Teklemariam | Sprint 2 | Feature/wireframe#1340
London | 26-MAY-ITP | Yonatan Teklemariam | Sprint 2 | Feature/wireframe#1340Yonatanteklemariam wants to merge 2 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Yonatanteklemariam
added
the
Needs Review
LonMcGregor
added
the
Review in progress
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work building this site - lots of interesting CSS choices
I've left some comments where you could improve further
| <p>A <strong>Git branch</strong> is a separate version of your project where you can work on new features without | ||
| affecting the | ||
| main code. Branches allow safe experimentation and make collaboration easier. Therefore.</p> | ||
| <a href="https://www.bing.com/ck/a?!&&p=a3106f4d918b1bd91968281781229db63f035c1379f56a2aaa6ebbb47092becfJmltdHM9MTc3OTMyMTYwMA&ptn=3&ver=2&hsh=4&fclid=208fb4e6-66f9-61be-37f1-a3e567b76078&psq=git+branching+means&u=a1aHR0cHM6Ly93d3cuZ2Vla3Nmb3JnZWVrcy5vcmcvZ2l0L2ludHJvZHVjdGlvbi10by1naXQtYnJhbmNoLw" |
There was a problem hiding this comment.
All of these links are, I guess, taken from a bing.com search? URLs like this can change over time and become invalid. Can you make them point to the correct URLs for the pages you wanted to point to?
|
|
||
| <article class="small-article"> | ||
| <img | ||
| src="https://thf.bing.com/th/id/OIP.e8ErcddqmrslMLMzf3tLUgHaEK?w=333&h=187&c=7&r=0&o=7&cb=thfc1falcon&dpr=1.3&pid=1.7&rm=3" |
There was a problem hiding this comment.
See my comment about the link URLs. Can you make these images have real src properties, rather than linking through bing?
| <div class="footer-note"> | ||
| <p>For more information, please contact us at: Email: <a href="mailto:info@mywireframedesign.com" | ||
| target="_blank">jante26uk@gmail.com</a></p> | ||
| <p>Telephone: <a href="tel:+1234567890" target="_blank">07350989507</a></p> |
There was a problem hiding this comment.
The telephone number visible on page doesn't match the one in the tel property. Similarly, the email doesn't match the mailto. Is there a reason for this?
| target="_blank">jante26uk@gmail.com</a></p> | ||
| <p>Telephone: <a href="tel:+1234567890" target="_blank">07350989507</a></p> | ||
| <p>Address: <a | ||
| href="https://www.google.com/maps/place/29+fauna+field,+dunstable/@51.8892291,-0.5159181,3a,75y,233.86h,90t/data=!3m4!1e1!3m2!1smLOk3gqmcMjC07E1hbElkg!2e0!4m2!3m1!1s0x48764f036c42a891:0xae3cf387fd9cf1dd?sa=X&ved=1t:3780&ictx=111" |
There was a problem hiding this comment.
Did you use your real address and contact details in this section? It's usually not a good idea to post this information publicly on the net
| target="_blank">29 | ||
| Fauna Field, Dusntable, UK</a></p><br> | ||
| </div> | ||
| <p>© 2026 My Wireframe Design. All rights reserved.</p> |
There was a problem hiding this comment.
According to the readme, the footer needs to be fixed to the bottom of the viewport. Have you achieved that criteria yet?
LonMcGregor
added
Reviewed
2 participants
Learners, PR Template
Self checklist
Changelist
-added wireframes and edited them according to the criteria.
-applied css styles to the wireframes according to the criteria.
Questions