Unhandled exception running "Reports->Network PDO".

[henri62]

Describe the bug
When running the Reports->Network PDO the app crashes.

To Reproduce
Steps to reproduce the behavior:

1. Open the attached xdd file.
2. Click on "Reports->Network PDO"
3. See error

Version used
v4.2.3-0.gc1071ab

Expected behavior
It shall not crash.

Screenshots
************** Exception Text **************
System.NullReferenceException: Object reference not set to an instance of an object.
at libEDSsharp.NetworkPDOreport.gennetpdodoc(String filepath, List`1 network) in D:\a\CANopenEditor\CANopenEditor\libEDSsharp\NetworkPDOreport.cs:line 182
at ODEditor.ODEditor_MainForm.networkPDOToolStripMenuItem_Click(Object sender, EventArgs e) in D:\a\CANopenEditor\CANopenEditor\EDSEditorGUI\Form1.cs:line 970
at System.Windows.Forms.ToolStripMenuItem.OnClick(EventArgs e)
at System.Windows.Forms.ToolStripItem.HandleClick(EventArgs e)
at System.Windows.Forms.ToolStripItem.HandleMouseUp(MouseEventArgs e)
at System.Windows.Forms.ToolStrip.OnMouseUp(MouseEventArgs mea)
at System.Windows.Forms.ToolStripDropDown.OnMouseUp(MouseEventArgs mea)
at System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks)
at System.Windows.Forms.Control.WndProc(Message& m)
at System.Windows.Forms.ToolStrip.WndProc(Message& m)
at System.Windows.Forms.NativeWindow.Callback(HWND hWnd, MessageId msg, WPARAM wparam, LPARAM lparam)

************** Loaded Assemblies **************
System.Private.CoreLib
Assembly Version: 8.0.0.0
Location: C:\Program Files\dotnet\shared\Microsoft.NETCore.App\8.0.27\System.Private.CoreLib.dll

EDSEditor
Assembly Version: 1.0.0.0
Location: C:\tools\CANOpen\net8.0-windows\EDSEditor.dll

System.Runtime
Assembly Version: 8.0.0.0
Location: C:\Program Files\dotnet\shared\Microsoft.NETCore.App\8.0.27\System.Runtime.dll

System.Windows.Forms
Assembly Version: 8.0.0.0
Location: C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App\8.0.27\System.Windows.Forms.dll

System.ComponentModel.Primitives
Assembly Version: 8.0.0.0
Location: C:\Program Files\dotnet\shared\Microsoft.NETCore.App\8.0.27\System.ComponentModel.Primitives.dll

System.Windows.Forms.Primitives
Assembly Version: 8.0.0.0
Location: C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App\8.0.27\System.Windows.Forms.Primitives.dll

System.Drawing.Primitives
Assembly Version: 8.0.0.0
Location: C:\Program Files\dotnet\shared\Microsoft.NETCore.App\8.0.27\System.Drawing.Primitives.dll

System.Collections.Specialized
Assembly Version: 8.0.0.0
Location: C:\Program Files\dotnet\shared\Microsoft.NETCore.App\8.0.27\System.Collections.Specialized.dll

System.Runtime.InteropServices
Assembly Version: 8.0.0.0
Location: C:\Program Files\dotnet\shared\Microsoft.NETCore.App\8.0.27\System.Runtime.InteropServices.dll

System.Threading
Assembly Version: 8.0.0.0
Location: C:\Program Files\dotnet\shared\Microsoft.NETCore.App\8.0.27\System.Threading.dll

System.Diagnostics.TraceSource
Assembly Version: 8.0.0.0
Location: C:\Program Files\dotnet\shared\Microsoft.NETCore.App\8.0.27\System.Diagnostics.TraceSource.dll

System.Collections
Assembly Version: 8.0.0.0
Location: C:\Program Files\dotnet\shared\Microsoft.NETCore.App\8.0.27\System.Collections.dll

libEDSsharp
Assembly Version: 1.0.0.0
Location: C:\tools\CANOpen\net8.0-windows\libEDSsharp.dll

System.Drawing.Common
Assembly Version: 8.0.0.0
Location: C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App\8.0.27\System.Drawing.Common.dll

System.Configuration.ConfigurationManager
Assembly Version: 8.0.0.0
Location: C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App\8.0.27\System.Configuration.ConfigurationManager.dll

System.ObjectModel
Assembly Version: 8.0.0.0
Location: C:\Program Files\dotnet\shared\Microsoft.NETCore.App\8.0.27\System.ObjectModel.dll

Microsoft.Win32.Primitives
Assembly Version: 8.0.0.0
Location: C:\Program Files\dotnet\shared\Microsoft.NETCore.App\8.0.27\Microsoft.Win32.Primitives.dll

System.ComponentModel.EventBasedAsync
Assembly Version: 8.0.0.0
Location: C:\Program Files\dotnet\shared\Microsoft.NETCore.App\8.0.27\System.ComponentModel.EventBasedAsync.dll

System.Threading.Thread
Assembly Version: 8.0.0.0
Location: C:\Program Files\dotnet\shared\Microsoft.NETCore.App\8.0.27\System.Threading.Thread.dll

Accessibility
Assembly Version: 4.0.0.0
Location: C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App\8.0.27\Accessibility.dll

System.ComponentModel.TypeConverter
Assembly Version: 8.0.0.0
Location: C:\Program Files\dotnet\shared\Microsoft.NETCore.App\8.0.27\System.ComponentModel.TypeConverter.dll

Microsoft.Win32.SystemEvents
Assembly Version: 8.0.0.0
Location: C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App\8.0.27\Microsoft.Win32.SystemEvents.dll

System.Collections.Concurrent
Assembly Version: 8.0.0.0
Location: C:\Program Files\dotnet\shared\Microsoft.NETCore.App\8.0.27\System.Collections.Concurrent.dll

System.ComponentModel
Assembly Version: 8.0.0.0
Location: C:\Program Files\dotnet\shared\Microsoft.NETCore.App\8.0.27\System.ComponentModel.dll

System.Numerics.Vectors
Assembly Version: 8.0.0.0
Location: C:\Program Files\dotnet\shared\Microsoft.NETCore.App\8.0.27\System.Numerics.Vectors.dll

System.Memory
Assembly Version: 8.0.0.0
Location: C:\Program Files\dotnet\shared\Microsoft.NETCore.App\8.0.27\System.Memory.dll

System.Runtime.Loader
Assembly Version: 8.0.0.0
Location: C:\Program Files\dotnet\shared\Microsoft.NETCore.App\8.0.27\System.Runtime.Loader.dll

System.Resources.Extensions
Assembly Version: 8.0.0.0
Location: C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App\8.0.27\System.Resources.Extensions.dll

System.Drawing
Assembly Version: 8.0.0.0
Location: C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App\8.0.27\System.Drawing.dll

System.Linq
Assembly Version: 8.0.0.0
Location: C:\Program Files\dotnet\shared\Microsoft.NETCore.App\8.0.27\System.Linq.dll

System.Private.Uri
Assembly Version: 8.0.0.0
Location: C:\Program Files\dotnet\shared\Microsoft.NETCore.App\8.0.27\System.Private.Uri.dll

System.Security.Cryptography
Assembly Version: 8.0.0.0
Location: C:\Program Files\dotnet\shared\Microsoft.NETCore.App\8.0.27\System.Security.Cryptography.dll

System.Xml.ReaderWriter
Assembly Version: 8.0.0.0
Location: C:\Program Files\dotnet\shared\Microsoft.NETCore.App\8.0.27\System.Xml.ReaderWriter.dll

System.Private.Xml
Assembly Version: 8.0.0.0
Location: C:\Program Files\dotnet\shared\Microsoft.NETCore.App\8.0.27\System.Private.Xml.dll

System.Net.WebClient
Assembly Version: 8.0.0.0
Location: C:\Program Files\dotnet\shared\Microsoft.NETCore.App\8.0.27\System.Net.WebClient.dll

System.Text.Encoding.Extensions
Assembly Version: 8.0.0.0
Location: C:\Program Files\dotnet\shared\Microsoft.NETCore.App\8.0.27\System.Text.Encoding.Extensions.dll

System
Assembly Version: 4.0.0.0
Location: C:\Program Files\dotnet\shared\Microsoft.NETCore.App\8.0.27\System.dll

System.Runtime.Serialization.Formatters
Assembly Version: 8.0.0.0
Location: C:\Program Files\dotnet\shared\Microsoft.NETCore.App\8.0.27\System.Runtime.Serialization.Formatters.dll

System.Xml.XmlSerializer
Assembly Version: 8.0.0.0
Location: C:\Program Files\dotnet\shared\Microsoft.NETCore.App\8.0.27\System.Xml.XmlSerializer.dll

System.Collections.NonGeneric
Assembly Version: 8.0.0.0
Location: C:\Program Files\dotnet\shared\Microsoft.NETCore.App\8.0.27\System.Collections.NonGeneric.dll

System.Text.RegularExpressions
Assembly Version: 8.0.0.0
Location: C:\Program Files\dotnet\shared\Microsoft.NETCore.App\8.0.27\System.Text.RegularExpressions.dll

System.Reflection.Emit.ILGeneration
Assembly Version: 8.0.0.0
Location: C:\Program Files\dotnet\shared\Microsoft.NETCore.App\8.0.27\System.Reflection.Emit.ILGeneration.dll

System.Reflection.Emit
Assembly Version: 8.0.0.0
Location: C:\Program Files\dotnet\shared\Microsoft.NETCore.App\8.0.27\System.Reflection.Emit.dll

Microsoft.GeneratedCode
Assembly Version: 1.0.0.0
Location:

System.Reflection.Primitives
Assembly Version: 8.0.0.0
Location: C:\Program Files\dotnet\shared\Microsoft.NETCore.App\8.0.27\System.Reflection.Primitives.dll

SourceGrid
Assembly Version: 6.0.0.0
Location: C:\tools\CANOpen\net8.0-windows\SourceGrid.dll

mscorlib
Assembly Version: 4.0.0.0
Location: C:\Program Files\dotnet\shared\Microsoft.NETCore.App\8.0.27\mscorlib.dll

System.Console
Assembly Version: 8.0.0.0
Location: C:\Program Files\dotnet\shared\Microsoft.NETCore.App\8.0.27\System.Console.dll

System.Diagnostics.Process
Assembly Version: 8.0.0.0
Location: C:\Program Files\dotnet\shared\Microsoft.NETCore.App\8.0.27\System.Diagnostics.Process.dll

System.Diagnostics.StackTrace
Assembly Version: 8.0.0.0
Location: C:\Program Files\dotnet\shared\Microsoft.NETCore.App\8.0.27\System.Diagnostics.StackTrace.dll

System.Reflection.Metadata
Assembly Version: 8.0.0.0
Location: C:\Program Files\dotnet\shared\Microsoft.NETCore.App\8.0.27\System.Reflection.Metadata.dll

System.Collections.Immutable
Assembly Version: 8.0.0.0
Location: C:\Program Files\dotnet\shared\Microsoft.NETCore.App\8.0.27\System.Collections.Immutable.dll

System.IO.MemoryMappedFiles
Assembly Version: 8.0.0.0
Location: C:\Program Files\dotnet\shared\Microsoft.NETCore.App\8.0.27\System.IO.MemoryMappedFiles.dll

Additional context
Maybe has todo with a PDO mapping to an OCTET_STRING?

files upload

cleanopen-geesinknorba.zip

[trojanobelix]

Same bug reportet as #161

[henri62]

I checked it in the debugger, but it looks a different bug. The result is the same: The program crashes. But the root cause is different.

In the debugger it faiils here:
name = eds.ods[index].Getsubobject(subindex).parameter_name;
The index is 8192 = 0x2000 and subindex is 1, so far looks good.
But the content of subobjects seems to be empty.

I found out the root cause: The SDO 0x2000 has no sub 0x00 (highest sub-index supported) and 0x01( the variable itself), that was my mistake so an error in the definition. Or I need to fill in default value of 0x20000040 for the mapping.

But at least a check should be present that something is missing. I will try to see how a check and message can be added to it.

Please reopen this ticket?

-edit-
The TPDO mapping should have been 0x20000040 (so not 0x20000140) that fixes my xdd file like it should be.

[henri62]

I changed this in "libEDSshard/NetworkPDOreport.cs" @ line 182:

Original:
                                    name = eds.ods[index].Getsubobject(subindex).parameter_name;
New:
                                    ODentry current_sdo = eds.ods[index].Getsubobject(subindex);
                                    if (current_sdo == null)
                                    {
                                        name = string.Format("<p style=\"color: red;\">Error: subindex is missing in SDO!</p>");
                                    }
                                    else
                                    {
                                        name = current_sdo.parameter_name;
                                    }

Feel free to use it/rewrite it or just pop-up some error (don't know if it may be done in the reporter?).

At least the code does not crash, the report now shows a clearly visible error in the report.

-edit- Maybe its better to use a class=error so the color can be set elsewhere? Does such exists anywhere?
I see a EDSEditorGUI\style.css files, maybe put in an .error class there? -> Checked it and works.

Shall I fork the repo and make a pull request for the above fix (with the a style sheet ref)?