Skip to content

[PWGLF] refactor nucleiqc logic, fixed previous errors#15980

Merged
maciacco merged 4 commits into
AliceO2Group:masterfrom
GiorgioAlbertoLucia:nucleiqc_new
Apr 27, 2026
Merged

[PWGLF] refactor nucleiqc logic, fixed previous errors#15980
maciacco merged 4 commits into
AliceO2Group:masterfrom
GiorgioAlbertoLucia:nucleiqc_new

Conversation

@GiorgioAlbertoLucia

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented Apr 27, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 5 errors, ⚠️ 41 warnings, 🔕 0 disabled

@GiorgioAlbertoLucia GiorgioAlbertoLucia marked this pull request as ready for review April 27, 2026 14:37
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for ab9de14 at 2026-04-27 16:54:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:152:10: error: 'PDG_t' has not been declared
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:250:44: error: 'PDG_t' has not been declared
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:322:84: error: 'kIsTriggerTVX' is not a member of 'o2::aod::evsel'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:332:89: error: 'kNoTimeFrameBorder' is not a member of 'o2::aod::evsel'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:337:93: error: 'kNoITSROFrameBorder' is not a member of 'o2::aod::evsel'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:342:98: error: 'kNoSameBunchPileup' is not a member of 'o2::aod::evsel'; did you mean 'nuclei::kNoSameBunchPileup'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:347:98: error: 'kIsGoodZvtxFT0vsPV' is not a member of 'o2::aod::evsel'; did you mean 'nuclei::kIsGoodZvtxFT0vsPV'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:352:99: error: 'kIsGoodITSLayersAll' is not a member of 'o2::aod::evsel'; did you mean 'nuclei::kIsGoodITSLayersAll'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:152:10: error: 'PDG_t' has not been declared
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:250:44: error: 'PDG_t' has not been declared
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:322:84: error: 'kIsTriggerTVX' is not a member of 'o2::aod::evsel'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:332:89: error: 'kNoTimeFrameBorder' is not a member of 'o2::aod::evsel'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:337:93: error: 'kNoITSROFrameBorder' is not a member of 'o2::aod::evsel'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:342:98: error: 'kNoSameBunchPileup' is not a member of 'o2::aod::evsel'; did you mean 'nuclei::kNoSameBunchPileup'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:347:98: error: 'kIsGoodZvtxFT0vsPV' is not a member of 'o2::aod::evsel'; did you mean 'nuclei::kIsGoodZvtxFT0vsPV'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:352:99: error: 'kIsGoodITSLayersAll' is not a member of 'o2::aod::evsel'; did you mean 'nuclei::kIsGoodITSLayersAll'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/TableProducer/QC/nucleiQC.cxx:384:50: error: 'kNoITSROFrameBorder' is not a member of 'o2::aod::evsel'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:152:10: error: 'PDG_t' has not been declared
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:250:44: error: 'PDG_t' has not been declared
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:322:84: error: 'kIsTriggerTVX' is not a member of 'o2::aod::evsel'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:332:89: error: 'kNoTimeFrameBorder' is not a member of 'o2::aod::evsel'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:337:93: error: 'kNoITSROFrameBorder' is not a member of 'o2::aod::evsel'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:342:98: error: 'kNoSameBunchPileup' is not a member of 'o2::aod::evsel'; did you mean 'nuclei::kNoSameBunchPileup'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:347:98: error: 'kIsGoodZvtxFT0vsPV' is not a member of 'o2::aod::evsel'; did you mean 'nuclei::kIsGoodZvtxFT0vsPV'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:352:99: error: 'kIsGoodITSLayersAll' is not a member of 'o2::aod::evsel'; did you mean 'nuclei::kIsGoodITSLayersAll'?
ninja: build stopped: subcommand failed.

Full log here.

@vkucera vkucera marked this pull request as draft April 27, 2026 15:19
@vkucera

vkucera commented Apr 27, 2026

Copy link
Copy Markdown
Collaborator

@GiorgioAlbertoLucia Your PR does not compile on any system. How did you test it?

Comment thread PWGLF/TableProducer/QC/nucleiQC.cxx
@GiorgioAlbertoLucia GiorgioAlbertoLucia marked this pull request as ready for review April 27, 2026 15:40
@GiorgioAlbertoLucia

GiorgioAlbertoLucia commented Apr 27, 2026

Copy link
Copy Markdown
Contributor Author

@GiorgioAlbertoLucia Your PR does not compile on any system. How did you test it?

Ciao @vkucera, it was building locally (ubuntu 24.04). It looked like the issues were some includes, I probably messed up something in the merge procedure, in fact your changes to the includes were not present in my PR.

I reverted to your include version and it still builds locally. Let's see

@maciacco maciacco enabled auto-merge (squash) April 27, 2026 22:25
@maciacco maciacco merged commit 71bb524 into AliceO2Group:master Apr 27, 2026
12 of 14 checks passed
@GiorgioAlbertoLucia GiorgioAlbertoLucia deleted the nucleiqc_new branch June 8, 2026 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants