Enhance Hindi translations in hi-in.json#2124
Conversation
- file edited hi-in.json
Greptile SummaryThis PR translates a large batch of previously untranslated (English) strings in
Confidence Score: 4/5Safe to merge after fixing the singular/plural mismatch in the LSP file-removal confirmation string. The translation is comprehensive and largely accurate. One string — the LSP file-removal confirmation — uses the singular Hindi noun फ़ाइल where the original English says files (plural), which would display grammatically incorrect text to Hindi users triggering that action. src/lang/hi-in.json — specifically the lsp-remove-installed-files entry. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[hi-in.json] --> B[Settings Info Strings]
A --> C[Quicktools Labels]
A --> D[Backup / Restore Strings]
A --> E[LSP Server Strings]
B --> B1["info-* keys translated\n~25 entries"]
C --> C1["quicktools:* keys translated\n~15 entries"]
D --> D1["collecting/creating/validating\nrestoring strings"]
D --> D2["⚠️ 4 strings missing trailing period"]
E --> E1["lsp-feature-*, lsp-install-*\nlsp-status-*, lsp-error-* translated"]
E --> E2["⚠️ lsp-remove-installed-files\nफ़ाइल → फ़ाइलें (plural fix needed)"]
Reviews (3): Last reviewed commit: "Fix translation of key bindings and plug..." | Re-trigger Greptile |
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
|
@greptile |
|
@greptile review again (just a minor) |
|
@greptile create suggestive comments for that |
|
Great translations overall! Here are a few specific suggestions to address consistency and correctness issues: 1. Inconsistent spelling of "चिह्न" (symbol) —
2. Missing trailing periods in backup progress strings The surrounding entries ( 3. Wrong number (singular vs. plural) for
4. Toast notifications should reflect completion, not current state The English originals say "Server disabled/enabled" (past tense — action done). The current translations read as present state ("the server is inactive/active"). Suggested fix: 5. Inconsistent translation of "initialization options"
6. Several |
after testing i found line no 272 needs correction from current commit to |
|
Translation correction — The current translation places the condition before the subject, which reads awkwardly:
Moving FTP/SFTP to the front makes it more natural Hindi, with the subject stated first: Why:
|
|
Here are the suggestive inline review comments for this PR: 1. Plural error — The English source says "files" (plural), but the Hindi translation uses the singular "फ़ाइल". 2. Inconsistency — The paired entry 3. Punctuation inconsistency — The sibling progress strings ( 4. Extra period — The original English Overall this is a solid, thorough translation — the four issues above are the main things worth cleaning up before merge. |
No description provided.